Re: [PATCH] iio: resolver: ad2s1200: use dev_err_probe()

[Joshua Crofts]

On Thu, 16 Jul 2026 14:31:00 +0200
Vojtěch Krátký <vo.kratky@xxxxxxxxx> wrote:

> Use dev_err_probe() instead of dev_err() to simplify the error path
> and cleanly handle deferred probing.
> 
> Signed-off-by: Vojtěch Krátký <vo.kratky@xxxxxxxxx>
> ---
>  drivers/iio/resolver/ad2s1200.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/resolver/ad2s1200.c b/drivers/iio/resolver/ad2s1200.c
> index 55bcbbd4021a..7c7ce0e2f9cc 100644
> --- a/drivers/iio/resolver/ad2s1200.c
> +++ b/drivers/iio/resolver/ad2s1200.c
> @@ -144,16 +144,14 @@ static int ad2s1200_probe(struct spi_device *spi)
>  
>  	st->sample = devm_gpiod_get(&spi->dev, "adi,sample", GPIOD_OUT_LOW);
>  	if (IS_ERR(st->sample)) {
> -		dev_err(&spi->dev, "Failed to claim SAMPLE gpio: err=%ld\n",
> -			PTR_ERR(st->sample));
> -		return PTR_ERR(st->sample);
> +		return dev_err_probe(&spi->dev, PTR_ERR(st->sample),
> +				"Failed to claim SAMPLE gpio\n");

Please align the error message with the parenthesis, i.e.

> +		return dev_err_probe(&spi->dev, PTR_ERR(st->sample),
> +				     "Failed to claim SAMPLE gpio\n");

Same goes for the other change in this patch.

-- 
Kind regards

CJD