Re: [PATCH] iio: resolver: ad2s1200: use dev_err_probe()

[Andy Shevchenko]

On Thu, Jul 16, 2026 at 02:31:00PM +0200, Vojtěch Krátký wrote:
> Use dev_err_probe() instead of dev_err() to simplify the error path
> and cleanly handle deferred probing.

...

>  	st->sample = devm_gpiod_get(&spi->dev, "adi,sample", GPIOD_OUT_LOW);
>  	if (IS_ERR(st->sample)) {
> -		dev_err(&spi->dev, "Failed to claim SAMPLE gpio: err=%ld\n",
> -			PTR_ERR(st->sample));
> -		return PTR_ERR(st->sample);
> +		return dev_err_probe(&spi->dev, PTR_ERR(st->sample),
> +				"Failed to claim SAMPLE gpio\n");
>  	}

As Markus said, you can drop {}. On top of that you can introduce

	struct device *dev = &spi->dev;

at the top of the function and make this all shorter.

	if (IS_ERR(st->sample))
		return dev_err_probe(dev, PTR_ERR(st->sample),
				     "Failed to claim SAMPLE gpio\n");

...

>  	st->rdvel = devm_gpiod_get(&spi->dev, "adi,rdvel", GPIOD_OUT_LOW);
>  	if (IS_ERR(st->rdvel)) {
> -		dev_err(&spi->dev, "Failed to claim RDVEL gpio: err=%ld\n",
> -			PTR_ERR(st->rdvel));
> -		return PTR_ERR(st->rdvel);
> +		return dev_err_probe(&spi->dev, PTR_ERR(st->rdvel),
> +				"Failed to claim RDVEL gpio\n");
>  	}

Ditto.

-- 
With Best Regards,
Andy Shevchenko