Re: [PATCH 3/3] mm/mseal: remove further superfluous comments, do_mseal()
From: Lorenzo Stoakes (ARM)
Date: Thu Jul 16 2026 - 11:14:19 EST
On Thu, Jul 16, 2026 at 04:09:14PM +0100, Pedro Falcato wrote:
> On Thu, Jul 16, 2026 at 02:43:11PM +0100, Lorenzo Stoakes (ARM) wrote:
> > There's no need to abstract do_mseal() any longer so put the system call
> > implementation in the system call declaration.
>
> This looks great!
>
> >
> > The comment around do_mseal() is strangely formatted, overly long and adds
> > a lot of superfluous information that the code already provides, so boil it
> > down to the essentials.
>
> But I would much rather we delete the whole comment (like Leon's patch did,
> per my request). Do you disagree?
I would like us to retain the information I added yes. Removing that is not
really helpful I don't think.
>
> >
> > Signed-off-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
>
> Anyway,
>
> Reviewed-by: Pedro Falcato <pfalcato@xxxxxxx>
Thanks!
>
> --
> Pedro
Cheers, Lorenzo