Re: [PATCH v3] PCI: starfive: Fix resource leaks on error paths in host_init()
From: Manivannan Sadhasivam
Date: Thu Jul 16 2026 - 13:19:23 EST
On Thu, 16 Jul 2026 15:20:53 +0500, Ali Tariq wrote:
> starfive_pcie_host_init() acquires the PHY, clocks/resets, and an
> optional regulator in sequence, but does not correctly unwind these
> resources when a later step fails.
>
> If starfive_pcie_clk_rst_init() fails after the PHY has already been
> successfully enabled, the function returns directly without disabling
> the PHY, leaking it and leaving it powered.
>
> [...]
Applied, thanks!
[1/1] PCI: starfive: Fix resource leaks on error paths in host_init()
commit: 22877a061f81c5d58041e384b3131684bec636b9
Best regards,
--
மணிவண்ணன் சதாசிவம்