Re: [PATCH v6 6/6] arm64: dts: qcom: Add device tree for Nord RRD board

[Konrad Dybcio]

On 7/16/26 4:26 PM, Shawn Guo wrote:
> Add initial device tree for the Qualcomm Dragonwing IQ10 RRD (Robotics
> Reference Design) board, which is built on Nord Embedded variant. Enable
> the debug UART, UFS storage, PMICs, I2C and SPI.
> 
> Co-developed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> ---

[...]

> +	/* PMIC A - Kobra_MM (PMM8650AU) - SID 0x0, Bus E0 */

This comment is very useful

> +	regulators-0 {
> +		compatible = "qcom,pmm8654au-rpmh-regulators";
> +		qcom,pmic-id = "A_E0";
> +
> +		/* LDO Regulators */

This is much less so

[...]

> +		vreg_l7a_1p2: ldo7 {
> +			regulator-name = "vreg_l7a_1p2";
> +			regulator-min-microvolt = <1200000>;
> +			regulator-max-microvolt = <1200000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +			regulator-always-on;
> +			regulator-boot-on;
> +			regulator-allow-set-load;

You made a lot of the regulators always-/boot-on - are you sure about
each one of them?

> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;

It's commonplace to restrict regulators to HPM only because not all of
the drivers that should be voting on desired load actually do it. Do
you have any intermittent failures, particularly around PHYs?

[...]


> +&i2c7 {
> +	clock-frequency = <400000>;
> +
> +	status = "okay";

It's commonplace to add comments like:

/* Type-C controller @ 0x15 */

Otherwise this lgtm

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad