Re: [PATCH v6 6/6] arm64: dts: qcom: Add device tree for Nord RRD board

[Bartosz Golaszewski]

On Thu, 16 Jul 2026 19:17:14 +0200, Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxxxx> said:
> On 7/16/26 4:26 PM, Shawn Guo wrote:
>> Add initial device tree for the Qualcomm Dragonwing IQ10 RRD (Robotics
>> Reference Design) board, which is built on Nord Embedded variant. Enable
>> the debug UART, UFS storage, PMICs, I2C and SPI.
>>
>> Co-developed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
>> ---
>
> [...]
>
>> +	/* PMIC A - Kobra_MM (PMM8650AU) - SID 0x0, Bus E0 */
>
> This comment is very useful
>
>> +	regulators-0 {
>> +		compatible = "qcom,pmm8654au-rpmh-regulators";
>> +		qcom,pmic-id = "A_E0";
>> +
>> +		/* LDO Regulators */
>
> This is much less so
>
> [...]
>
>> +		vreg_l7a_1p2: ldo7 {
>> +			regulator-name = "vreg_l7a_1p2";
>> +			regulator-min-microvolt = <1200000>;
>> +			regulator-max-microvolt = <1200000>;
>> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> +			regulator-always-on;
>> +			regulator-boot-on;
>> +			regulator-allow-set-load;
>
> You made a lot of the regulators always-/boot-on - are you sure about
> each one of them?
>

I double checked and for vreg_l3e_1p8 and vreg_l2i_1p2 we can drop the flags.
The first one feeds the efuse, the second UFS. The rest is fine.

Bart