Re: [PATCH v4] usb: musb: dsps: implement vbus_status and set_vbus platform ops
From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Fri Jul 17 2026 - 05:55:40 EST
On Thu, Jul 16, 2026 at 05:05:54PM +0000, Lucas Martins Alves wrote:
> From: Lucas Martins Alves <lucas.alves@xxxxxxxxxxxxxx>
>
> The DSPS glue layer (used on TI AM335x SoCs) was missing implementations
> for the vbus_status and set_vbus platform ops defined in struct
> musb_platform_ops.
>
> Add dsps_musb_vbus_status() to report VBUS presence by reading the VBUS
> field of MUSB_DEVCTL, and dsps_musb_set_vbus() to drive the SESSION bit
> on MUSB_DEVCTL, enabling or disabling the USB session.
>
> Register both callbacks in dsps_ops to allow the MUSB core to control
> VBUS on AM335x-based platforms. This enables the USB core to perform a
> VBUS power cycle as a recovery mechanism when a USB error condition is
> detected, and also allows userspace to control VBUS state via the
> standard USB sysfs interface.
>
> Signed-off-by: Lucas Martins Alves <lucas.alves@xxxxxxxxxxxxxx>
> ---
> v1 -> v2:
> - remove musb_root_disconnect() from set_vbus path
> - adjust context->devctl copy/update handling
>
> v2 -> v3:
> - fix patch description text
> - fix devctl usage in set_vbus path
> ---
> drivers/usb/musb/musb_dsps.c | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
I'm confused, what about patch 2?
THis series is all intermixed, can you start a new thread, and send just
what you want reviewed/accepted here? I'm lost...
thanks,
gre k-h