RE: [PATCH v4] usb: musb: dsps: implement vbus_status and set_vbus platform ops

[Lucas Martins Alves]

Hi,
I would like to apologize for the confusion regarding the previous patch submissions.
I generate and manage patches from an environment with restricted email access. As a result, I am unable to use the traditional patch submission tools and workflows, which unfortunately led to several mistakes while sending this patch series.
To avoid further confusion, I have recreated and resubmitted the patches as:
[PATCH v5] usb: musb: dsps: implement vbus_status and set_vbus platform ops
This version correctly reflects the changes that I intended to submit for review. Please disregard the earlier submissions and use the v5 patch as the basis for any review comments.
I apologize for the noise caused by the previous iterations and appreciate your patience and feedback.
Thank you for your time and review.
Best regards,

Lucas Martins Alves


________________________________________
De: gregkh@xxxxxxxxxxxxxxxxxxx <gregkh@xxxxxxxxxxxxxxxxxxx>
Enviado: sexta-feira, 17 de julho de 2026 06:41
Para: Lucas Martins Alves <lucas.alves@xxxxxxxxxxxxxx>
Cc: b-liu@xxxxxx <b-liu@xxxxxx>; linux-usb@xxxxxxxxxxxxxxx <linux-usb@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>
Assunto: Re: [PATCH v4] usb: musb: dsps: implement vbus_status and set_vbus platform ops
 
On Thu, Jul 16, 2026 at 05:05:54PM +0000, Lucas Martins Alves wrote:
> From: Lucas Martins Alves <lucas.alves@xxxxxxxxxxxxxx>
>
> The DSPS glue layer (used on TI AM335x SoCs) was missing implementations
> for the vbus_status and set_vbus platform ops defined in struct
> musb_platform_ops.
>
> Add dsps_musb_vbus_status() to report VBUS presence by reading the VBUS
> field of MUSB_DEVCTL, and dsps_musb_set_vbus() to drive the SESSION bit
> on MUSB_DEVCTL, enabling or disabling the USB session.
>
> Register both callbacks in dsps_ops to allow the MUSB core to control
> VBUS on AM335x-based platforms. This enables the USB core to perform a
> VBUS power cycle as a recovery mechanism when a USB error condition is
> detected, and also allows userspace to control VBUS state via the
> standard USB sysfs interface.
>
> Signed-off-by: Lucas Martins Alves <lucas.alves@xxxxxxxxxxxxxx>
> ---
> v1 -> v2:
> - remove musb_root_disconnect() from set_vbus path
> - adjust context->devctl copy/update handling
>
> v2 -> v3:
> - fix patch description text
> - fix devctl usage in set_vbus path
> ---
>  drivers/usb/musb/musb_dsps.c | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

I'm confused, what about patch 2?

THis series is all intermixed, can you start a new thread, and send just
what you want reviewed/accepted here?  I'm lost...

thanks,

gre k-h