RE: [PATCH net V3] net: phy: motorcomm: read EEE abilities in yt8521_get_features()

[Clark Wang]

> From: Clark Wang <xiaoning.wang@xxxxxxx>
> 
> In phy_probe(), genphy_c45_read_eee_abilities() is only called when a
> driver uses phydrv->features. Drivers that implement .get_features are
> responsible for reading the EEE abilities themselves.
> 
> yt8521_get_features() does not do this, so phydev->supported_eee stays
> empty for YT8521/YT8531S and "ethtool --show-eee" reports "EEE status:
> not supported", even though the PHY has the standard EEE capability
> registers.
> 
> Call genphy_c45_read_eee_abilities() at the end of yt8521_get_features()
> to populate supported_eee.
> 
> Fixes: 70479a40954c ("net: phy: Add driver for Motorcomm yt8521 gigabit
> ethernet phy")
> Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>
> Signed-off-by: Clark Wang <xiaoning.wang@xxxxxxx>
> ---
> V3 changes:
> - Replace the uncommon "ret ? : ..." expression with the usual
>   check, and move the check right after the first
> yt8521_get_features_paged()
>   call, which was the only path missing it.
> - Collect Reviewed tag from Breno.
> 
> V2 changes:
> - Return the value from genphy_c45_read_eee_abilities.
> ---

Sorry for the noise.
I think sashiko's discovery on V2 makes sense. I will fix the issues mentioned in V4.
https://sashiko.dev/#/patchset/20260710080018.1070789-1-xiaoning.wang@xxxxxxxxxxx?part=1

Best regards,
Clark Wang