[RFC PATCH v3 0/4] mm: avoid large folio splits when swap is unavailable
From: Xueyuan Chen
Date: Fri Jul 17 2026 - 08:31:33 EST
This is an RFC v3 of Barry's original RFC patch, "mm: Avoiding split
large folios if swap has no space":
https://lore.kernel.org/r/20260618221720.71768-1-baohua@xxxxxxxxxx
Barry's RFC showed the no-swap case with MADV_PAGEOUT on 16KB mTHP: the
large-folio split counter increased by 1024 even though no swapout
progress was possible. Skipping the split in that case kept the counter
at 0.
This version keeps that behavior, but makes folio_alloc_swap() classify
the failure. The helper has both the swap allocation result and the memcg
swap charge result, so callers only need to split when folio_alloc_swap()
reports that a smaller folio might still be swapped out.
Patch #1 adds page_counter_margin(), a small helper that computes the
minimum remaining chargeable space across a page_counter hierarchy.
Patch #2 uses that helper in the memcg swap path and lets
folio_alloc_swap() distinguish large-folio swap allocation failures:
- -E2BIG: splitting may let smaller folios make progress
- -ENOSPC: no global swap space is available
- -ENOMEM: splitting is not expected to help, including memcg swap
charge failures with no remaining swap capacity
Patch #3 makes vmscan split a large folio only when folio_alloc_swap()
returns -E2BIG. Other failures keep the existing activation path and avoid
destroying the large folio when no smaller part can be backed by swap
either.
Patch #4 applies the same contract to shmem_writeout(), which previously
split a large folio on every folio_alloc_swap() failure. It now enters the
split fallback only on -E2BIG; other failures redirty and reactivate the
folio as before.
RFC v2 -> RFC v3:
- Use Johannes Weiner's original page_counter_margin() patch and preserve
his authorship. Move the mem_cgroup_get_nr_swap_pages() conversion into
Patch #1 so the helper addition remains a pure refactoring.
- Add Patch #4 to make shmem_writeout() split large folios only on -E2BIG,
as suggested by Baolin Wang.
- Previous version:
https://lore.kernel.org/r/20260709145124.764807-1-xueyuan.chen21@xxxxxxxxx
RFC v1 -> RFC v2:
- Split the RFC into helper, swap allocation, and vmscan patches.
- Add page_counter_margin() and use it for hierarchical memcg swap
capacity checks.
- Make folio_alloc_swap() return -E2BIG only when a smaller folio may
still be swapped out.
- Return -ENOSPC for no global swap space and -ENOMEM when splitting is
not expected to help, including memcg swap exhaustion.
- Make vmscan split large folios only on -E2BIG from folio_alloc_swap().
Barry Song (Xiaomi) (1):
mm/vmscan: avoid pointless large folio splits without swap
Johannes Weiner (1):
mm: add page_counter_margin()
Xueyuan Chen (2):
mm: distinguish large folio swap allocation failures
mm/shmem: split large folios only on -E2BIG
include/linux/page_counter.h | 1 +
include/linux/swap.h | 10 ++++++----
mm/memcontrol.c | 19 ++++++++++++-------
mm/page_counter.c | 17 +++++++++++++++++
mm/shmem.c | 6 ++++--
mm/swapfile.c | 21 +++++++++++++++------
mm/vmscan.c | 7 +++++--
7 files changed, 60 insertions(+), 21 deletions(-)
--
2.47.3