Re: [PATCH 1/4] regulator: dt-bindings: Add Silergy SYR82X allowed modes

[Krzysztof Kozlowski]

On 17/07/2026 14:02, Victor Krawiec wrote:
> On 7/17/26 11:08, Krzysztof Kozlowski wrote:
> 
>> On Wed, Jul 15, 2026 at 05:51:38PM +0200, Victor Krawiec wrote:
>>> Make the PWM mode configurable from devicetree. Some boards require forced
>>> PWM mode to keep the supply ripple within acceptable limits under light
>>> load conditions
>>>
>>> Indexes are starting from 1 to keep backward compatibility with existing
>>> device trees
>>>
>>> Signed-off-by: Victor Krawiec <victor.krawiec@xxxxxxxxxxx>
>>> ---
>>>  .../dt-bindings/regulator/silergy,syr82x.h    | 20 +++++++++++++++++++
>>>  1 file changed, 20 insertions(+)
>>>  create mode 100644 include/dt-bindings/regulator/silergy,syr82x.h
>>>
>> This header should be mentioned in the binding in property description.
> Thank you for the review. I'll add it to the binding in the next iteration.
>>> diff --git a/include/dt-bindings/regulator/silergy,syr82x.h b/include/dt-bindings/regulator/silergy,syr82x.h
>>> new file mode 100644
>>> index 000000000000..6d4aa86bb5c1
>>> --- /dev/null
>>> +++ b/include/dt-bindings/regulator/silergy,syr82x.h
>> Some confusing name. How is your binding file called? This must be the
>> same.
> 
> The binding file is named fcs,fan53555.yaml and handles several devices including the Silergy SYR82X which I was targeting in this patch serie. I will rename the header to have the same name as the binding file. Should I also rename the macros defined inside the header (SYR82X_REGULATOR_MODE_*) ?
> 
> The underlying implementation in the driver (in fan53555_device_mode_map_setup() it the patch serie) is limited to SYR82X because it is the only hardware that I'm able to test. That's why the binding part was referring to this specific device.
> 

So you are adding constants for one device but used in the bindings and
driver for other? Are they valid there?

The fcs,fan53555.yaml does not say that any modes are particularly valid.

Please wrap your replies.


Best regards,
Krzysztof