Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add Nuvoton MA35D1 EADC

[Rob Herring]

On Thu, Jul 16, 2026 at 7:59 PM Chi-Wen Weng <cwweng.linux@xxxxxxxxx> wrote:
>
> Hi Jonathan,
>
> Thank you for the review.
>
>  > Not sure this doc helps. What are these interrupts for?
>  > The driver only uses one of them so why are there 4?
>  >
>  > May well need interrupt-names to allow gaps in the list to
>  > work but hard to tell without more information.
>
> The hardware has four EADC interrupt outputs, ADINT0 to ADINT3. The
> conversion-complete source for each interrupt can be selected through
> the EADC interrupt source registers.
>
> However, this initial driver only uses sample module 0 and routes its
> end-of-conversion event to ADINT0. So the binding does not need to
> describe the unused interrupt outputs at this stage.
>
> I will simplify this in v3 and document only one interrupt entry for
> ADINT0. If support for the other ADINT lines is added later, the binding
> can be extended with interrupt-names at that point.

No, document what the h/w has, not what a driver currently uses. The
only exception I can think of here would be if only 1 interrupt pin is
usable on a given system. Then it would be just 1 interrupt with
interrupt-names to define which one is used.

Rob