Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add Nuvoton MA35D1 EADC

[Chi-Wen Weng]

Hi Rob,

Thank you for the clarification.

> No, document what the h/w has, not what a driver currently uses. The
> only exception I can think of here would be if only 1 interrupt pin is
> usable on a given system. Then it would be just 1 interrupt with
> interrupt-names to define which one is used.

Understood. I incorrectly based the binding on the current driver
implementation rather than the hardware resources.

MA35D1 has one EADC controller, EADC0, and all four interrupt outputs, 
ADINT0
through ADINT3, are connected to separate GIC interrupt lines.

ADINT0, ADINT1 and ADINT2 are generated from the corresponding ADIF0,
ADIF1 and ADIF2 conversion interrupt flags. ADINT3 is a shared interrupt
output and can be generated by ADIF3 or by any of the ADCMPF0 through
ADCMPF3 result-compare flags.

I will therefore keep all four interrupt entries in the v3 binding and
add interrupt-names for "adint0", "adint1", "adint2" and "adint3". The
ADINT3 description will state that it is shared by the conversion and
result-compare interrupt sources.

The initial driver will continue to request and use only "adint0", but
that implementation limitation will not restrict the hardware
description in the binding.

I will also remove the redundant maxItems property because the fixed
items list already specifies the number of interrupt entries.

Thanks,
Chi-Wen