Re: [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers

From: Matthew Wilcox

Date: Fri Jul 17 2026 - 13:30:26 EST


On Fri, Jul 17, 2026 at 03:20:54PM +0800, Hongfu Li wrote:
> From: Hongfu Li <lihongfu@xxxxxxxxxx>
>
> unlock_page(), end_page_writeback() and wait_on_page_writeback()
> are void wrappers forwarding to folio-based functions which also
> return void. Explicit return statements here are syntactically valid
> but unnecessary, and inconsistent with other nearby compat helpers
> such as mark_page_accessed() and set_page_writeback().
>
> Drop all these superfluous return keywords.

why bother? this file is temporary scaffolding. if they offend you so
much, work on removing the need for them.