Re: [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers

From: Hongfu Li

Date: Sun Jul 19 2026 - 21:37:35 EST


> > From: Hongfu Li <lihongfu@xxxxxxxxxx>
> >
> > unlock_page(), end_page_writeback() and wait_on_page_writeback()
> > are void wrappers forwarding to folio-based functions which also
> > return void. Explicit return statements here are syntactically valid
> > but unnecessary, and inconsistent with other nearby compat helpers
> > such as mark_page_accessed() and set_page_writeback().
> >
> > Drop all these superfluous return keywords.
>
> why bother? this file is temporary scaffolding. if they offend you so
> much, work on removing the need for them.

Thanks a lot for your comments.

I fully agree with your point. You've already made great progress cleaning
up this temporary scaffolding. I will follow your lead and keep working
on reducing usages of these helper functions.

Best regards,
Hongfu