Re: [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers

[David Hildenbrand (Arm)]

On 7/20/26 02:37, Hongfu Li wrote:
>>> From: Hongfu Li <lihongfu@xxxxxxxxxx>
>>>
>>> unlock_page(), end_page_writeback() and wait_on_page_writeback()
>>> are void wrappers forwarding to folio-based functions which also
>>> return void. Explicit return statements here are syntactically valid
>>> but unnecessary, and inconsistent with other nearby compat helpers
>>> such as mark_page_accessed() and set_page_writeback().
>>>
>>> Drop all these superfluous return keywords.
>>
>> why bother?  this file is temporary scaffolding.  if they offend you so
>> much, work on removing the need for them.
> 
> Thanks a lot for your comments.
> 
> I fully agree with your point. You've already made great progress cleaning
> up this temporary scaffolding. I will follow your lead and keep working
> on reducing usages of these helper functions.

As much as I agree, this patch here is perfectly fine.

-- 
Cheers,

David