Re: [PATCH 1/4] include/uapi/linux: add gxfp_ioctl.h for GXFP5130 fingerprint sensor
From: Greg KH
Date: Sat Jul 18 2026 - 05:09:33 EST
On Sat, Jul 18, 2026 at 11:14:28AM +0300, Metehan Günen wrote:
> Define the userspace ABI for the Goodix GXFP5130 eSPI fingerprint sensor
> driver:
>
> - struct gxfp_tap_hdr: header prepended to every read(2) record, carries
> payload length, MP protocol type and a ktime_get_ns() timestamp.
> - struct gxfp_tx_pkt_hdr: header that userspace prepends to write(2)
> payloads so the driver can wrap them in the eSPI frame format.
> - GXFP_IOCTL_FLUSH_RXQ: flush the kernel-side RX record queue.
>
> Signed-off-by: Metehan Günen <metehangnen@xxxxxxxxx>
> ---
> include/uapi/linux/gxfp_ioctl.h | 43 +++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 include/uapi/linux/gxfp_ioctl.h
>
> diff --git a/include/uapi/linux/gxfp_ioctl.h b/include/uapi/linux/gxfp_ioctl.h
> new file mode 100644
> index 000000000..c9c6c2d48
> --- /dev/null
> +++ b/include/uapi/linux/gxfp_ioctl.h
> @@ -0,0 +1,43 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __UAPI_GXFP_IOCTL_H
> +#define __UAPI_GXFP_IOCTL_H
> +
> +#include <linux/types.h>
> +#include <linux/ioctl.h>
> +
> +#define GXFP_IOCTL_MAGIC 'G'
Why do you get to use "G" here?