Re: [PATCH 1/4] include/uapi/linux: add gxfp_ioctl.h for GXFP5130 fingerprint sensor

[Metehan Günen]

On Sat, Jul 18, 2026 at 11:07:47AM +0200, Greg KH wrote:
> C variables do not start with _, this isn't rust :)
>
> And are you checking this for 0?

Will rename _rsvd0 to reserved and add a zero-check in v2:

  if (hdr.reserved != 0)
          return -EINVAL;

> Are you checking this for 0?

Same for _pad0: will rename to pad and add zero validation.

> No definition of what these flags are?

The flags field was placeholder code that was never wired up — there are
no flag values defined or used anywhere. I will remove the field entirely
in v2 to keep the ABI clean.

Thanks,
Metehan Günen