[PATCH 2/2] staging: media: atomisp: Mark pad_w and pad_h as const constants
From: Prajval Chaudhary
Date: Sun Jul 19 2026 - 10:11:10 EST
Now that the user-facing module parameters for pad_w and pad_h
have been removed, these variables are strictly internal driver
configurations. Mark them as const to prevent accidental runtime
modification and allow compiler optimization.
This completes the internal cleanup follow-up resulting from
addressing the driver's module parameter TODO item.
Signed-off-by: Prajval Chaudhary <prajvalchaudhari733@xxxxxxxxx>
---
drivers/staging/media/atomisp/pci/atomisp_common.h | 6 ++----
drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 4 ++--
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_common.h b/drivers/staging/media/atomisp/pci/atomisp_common.h
index a2462fc306fb..aa230c3708dd 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_common.h
+++ b/drivers/staging/media/atomisp/pci/atomisp_common.h
@@ -20,10 +20,8 @@
#include "ia_css.h"
-extern int dbg_level;
-extern int dbg_func;
-extern int pad_w;
-extern int pad_h;
+extern const int pad_w;
+extern const int pad_h;
/* Minimum padding requirements for ISP2400 (BYT) */
#define ISP2400_MIN_PAD_W 12
diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
index 5c2f5996a03f..5ca7e79fd1e5 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
@@ -53,9 +53,9 @@
* output res, and isp output res. however since we do not have this yet,
* the chosen solution is the next best thing.
*/
-int pad_w = 16;
+const int pad_w = 16;
-int pad_h = 16;
+const int pad_h = 16;
/*
* FIXME: this is a hack to make easier to support ISP2401 variant.
--
2.34.1