Re: [PATCH 1/2] staging: media: atomisp: Remove unused and unwanted debug module parameters
From: Andy Shevchenko
Date: Mon Jul 20 2026 - 07:00:07 EST
On Mon, Jul 20, 2026 at 01:38:01PM +0300, Dan Carpenter wrote:
> On Sun, Jul 19, 2026 at 07:33:49PM +0530, Prajval Chaudhary wrote:
> > Remove the unused module parameters 'dbg_level' and 'dbg_func'.
> > Additionally, remove the 'pad_w' and 'pad_h' module parameters
> > to prevent userspace from overriding internal ISP hardware padding
> > boundaries, leaving them as internal driver constants.
> >
> > This addresses the 'Remove unnecessary/unwanted module parameters'
> > task in the driver's TODO file.
> It's weird that the driver still has lots of references to these varaibles
> but the build didn't break for me...
Yeah, but still the debug facility should be updated to use what we have
in the kernel.
--
With Best Regards,
Andy Shevchenko