Re: [PATCH 2/2] iio: magnetometer: add support for QST QMC6308
From: Jonathan Cameron
Date: Sun Jul 19 2026 - 21:00:45 EST
On Wed, 15 Jul 2026 22:46:57 +0200
Jorijn van der Graaf <jorijnvdgraaf@xxxxxxxxxxxxx> wrote:
> On Tue, 14 Jul 2026 23:21:18 +0200, Uwe Kleine-König wrote:
> > On Tue, Jul 14, 2026 at 10:28:42PM +0200, Jorijn van der Graaf wrote:
> > > +#include <linux/i2c.h>
> > > +#include <linux/mod_devicetable.h>
> >
> > Please drop the include of <linux/mod_devicetable.h>. You need
> > i2c_device_id and of_device_id, both are provided by <linux/i2c.h>.
>
> Will do in v2, thanks,
> Jorijn
Hi Jorijn,
Welcome to IIO.
Small process thing. Don't send replies like this. They add
noise to the mailing list and we all have far too many emails
to read through! Instead put a note in the changelog for v2.
Basically we'll assume you have accepted any feedback you don't
reply to.
Note I send this email at least once a week to someone new!
Thanks,
Jonathan