Re: [PATCH 2/2] iio: magnetometer: add support for QST QMC6308

[Siratul Islam]

July 20, 2026 at 7:06 AM, "Jonathan Cameron" <jonathan.cameron@xxxxxxxxxxxxxxxx> wrote:


> 
> On Thu, 16 Jul 2026 19:06:51 +0000
> "Siratul Islam" <siratul.islam@xxxxxxxxx> wrote:
> 
> > 
> > July 16, 2026 at 8:18 PM, "Jorijn van der Graaf" wrote:
> >  
> >  ...
> >  > +#define QMC6308_AUTOSUSPEND_DELAY_MS 500
> >  > You can call it QMC6308_SLEEP_DELAY_MS to align with other values.
> >  > 
> >  I'd prefer to keep AUTOSUSPEND here: it names the mechanism the value
> >  feeds (pm_runtime_set_autosuspend_delay()) and matches yamaha-yas530
> >  and ak8974 in this directory.
> >  
> >  I can find atleast 10 drivers in IIO that uses *_SLEEP_DELAY_MS postfix
> >  for autosuspend delay value. So it's not a strong reason not to use it.
> > 
> This sort of thing tends to be author preference as both show up.
> AUTOSUSPEND is clearer in purpose so if anything would be my slight
> preference
> 
AUTOSUSPEND is a bit more specific, but it's too long and doesn't align
with other #defines. I was suggesting SLEEP because it would align perfectly
with all the other defines and there are existing drivers that use SLEEP.
> > 
...
> 

--
Best regards,
Sirat