Re: [PATCH v12 0/3] spi: pxa2xx: MacBook8,1 quirk, runtime PM, and LPSS S3 resume state fixes
From: Andy Shevchenko
Date: Mon Jul 20 2026 - 07:07:31 EST
On Sun, Jul 19, 2026 at 07:41:16PM +0800, Shih-Yuan Lee (FourDollars) wrote:
> On Sun, Jul 19, 2026 at 3:53 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> > On Sat, Jul 18, 2026 at 10:52:06PM +0800, Shih-Yuan Lee wrote:
...
> > > Changes in v12:
> > > - Addressed feedback from Sashiko review on the v11 patchset for Patch 2:
> > > - Preserved the if (!pm_runtime_suspended(dev)) check prior to enabling/disabling
> > > the clock in pxa2xx_spi_suspend() and pxa2xx_spi_resume(). On non-LPSS platforms,
> > > if a device was runtime suspended prior to system sleep, unconditionally enabling
> > > its hardware clock during system resume forced the clock ON while the PM core
> > > retained RPM_SUSPENDED. Restoring this check prevents PM state desynchronization,
> > > avoiding power leaks on non-LPSS platforms.
> >
> > What's going on here, please?
> >
> > It's v12 and you haven't even a thought to add the authors of the drivers, nor
> > any one from Intel whose SoCs are under the question here.a Besides that the patches
> > need more work.
>
> Understood. I will add the required authors/Intel folks and address
> the remaining issues for the next version.
>
> Could you please help provide the email addresses for the relevant
> Intel maintainers or authors I should include except the list below?
>
> $ ./scripts/get_maintainer.pl drivers/spi/spi-pxa2xx-pci.c drivers/spi/spi-pxa2xx.c drivers/spi/spi-pxa2xx.h
Compare to
$ ./scripts/get_maintainer.pl drivers/spi/spi-pxa2xx*
And on top of that: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>, Lukas Wunner <lukas@xxxxxxxxx>
--
With Best Regards,
Andy Shevchenko