Re: [PATCH net v3 2/3] net: ethernet: oa_tc6: Improvement in buffer overflow handling
From: Andrew Lunn
Date: Mon Jul 20 2026 - 16:33:02 EST
On Mon, Jul 20, 2026 at 07:09:22PM +0000, Selvamani Rajagopal wrote:
> >
> > [High]
> > Now that oa_tc6_prcs_rx_frame_end() returns int (and can return -EAGAIN
> > via oa_tc6_update_rx_skb() when tail + size > end), should the
> > "previous rx frame end + next rx frame start" branch also observe the
> > return value? That branch is not shown in the diff, but in the
> > resulting file it reads:
> >
> > if (start_valid && end_valid && start_byte_offset > end_byte_offset) {
>
>
> Andew and others,
>
> I don't know why my v3 submission is under "Archived" flag. "state" is still new and I was waiting
> for it to move to "Change requested" before submitting the next patch set. May be my understanding
> is wrong. Hope I can submit the following patch.
You should probably repost it.
The last couple of weeks things have been falling through the cracks
due to vacation and conferences. Reviewer time has been limited.
It might also help if all the TC6 developers work together and review
each others patches. Patchset having Reviewed-by: is more likely to
get accepted without one of "big" reviewers looking at it.
Andrew