Re: [PATCH net-next v5 10/13] net: phy: add generic helpers for direct C45 MMD access

[Paolo Abeni]

On 7/9/26 4:29 AM, Selvamani Rajagopal wrote:
> 
>> +int genphy_read_mmd_c45(struct phy_device *phydev, int devnum, u16 regnum)
>> +{
>> + struct mii_bus *bus = phydev->mdio.bus;
>> + int addr = phydev->mdio.addr;
> 
> You may want to insert the lockdep_assert here. That'll ensure that read/write APIs are called
> after the mdio-lock is taken. Andrew's suggestion.
> 
>    lockdep_assert_held(&bus->mdio_lock)
Since this looks like the only pending item and has no functional
implication, I think it's better handled as a (separate) follow-up.

/P