Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,sm8550-pas: Add Eliza CDSP compatible

[Abel Vesa]

On 26-07-22 10:01:18, Krzysztof Kozlowski wrote:
> On Tue, Jul 21, 2026 at 05:19:57PM +0300, Abel Vesa wrote:
> > Document compatible string for the CDSP Peripheral Authentication Service
> > on the Eliza SoC. It is not compatible with any other.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > ---
> >  .../bindings/remoteproc/qcom,sm8550-pas.yaml        | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > index 019db91be7fd..5492a88bb100 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > @@ -17,6 +17,7 @@ properties:
> >    compatible:
> >      oneOf:
> >        - enum:
> > +          - qcom,eliza-cdsp-pas
> >            - qcom,sdx75-mpss-pas
> >            - qcom,sm8550-adsp-pas
> >            - qcom,sm8550-cdsp-pas
> > @@ -173,6 +174,7 @@ allOf:
> >          compatible:
> >            contains:
> >              enum:
> > +              - qcom,eliza-cdsp-pas
> >                - qcom,sm8750-cdsp-pas
> >      then:
> >        properties:
> > @@ -288,6 +290,25 @@ allOf:
> >              - const: mxc
> >              - const: nsp
> >  
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - qcom,eliza-cdsp-pas
> > +    then:
> > +      properties:
> > +        power-domains:
> > +          items:
> > +            - description: CX power domain
> > +            - description: MX power domain
> > +            - description: NSP power domain
> > +        power-domain-names:
> > +          items:
> > +            - const: cx
> > +            - const: mx
> 
> We need to stop using here provider names. This is the same as mxc of
> other generations like SM8650, because it is for this core a VDD_M or
> VDD_M_2 power domain.
> 
> Using provider names causes unnecessary bindings bloat and possibly fake
> driver differences.

I agree.

> 
> Well, not a problem of this patch.

Will try to send a separate fix.

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Thanks for reviewing!