Re: [PATCH net-next 3/7] dt-bindings: net: xlnx,axi-ethernet: Add 10G/25G (XXV) ethernet

[Rob Herring (Arm)]

On Thu, 23 Jul 2026 18:08:34 +0530, Suraj Gupta wrote:
> The XXV Ethernet IP integrates a 10G/25G Ethernet MAC with an in-core
> PCS/PMA driving a high-speed serial transceiver. Extend the existing
> xlnx,axi-ethernet binding to describe it.
> 
> Add the "xlnx,xxv-ethernet-1.0" compatible and make the resource
> requirements conditional based on the XXV compatible string:
> 
>   - "dmas", "dma-names", and "phy-mode" are required.
>   - Interrupt properties are not required as it does not have a dedicated
>     Ethernet core interrupt.
>   - "phy-handle" is not required as it has internal PCS and PMA.
>   - Add the 10gbase-r and 25gbase-r phy-mode values used by XXV.
> Annotate the existing compatibles, generalise the title to cover both
> variants, and add an example node for XXV.
> 
> Define properties at top level per binding style and use if/then to
> constrain requirements and phy-mode per compatible. Forbid 1G-only and
> unused ethernet-controller properties on XXV nodes.
> 
> Signed-off-by: Suraj Gupta <suraj.gupta2@xxxxxxx>
> ---
>  .../bindings/net/xlnx,axi-ethernet.yaml       | 144 ++++++++++++++----
>  1 file changed, 117 insertions(+), 27 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml: allOf:2:then:properties:clocks: {'maxItems': 3, 'items': [{'description': 'RX AXI4-Stream clock (rx_core_clk).'}, {'description': 'GT DRP clock (dclk).'}, {'description': 'AXI4-Lite register clock (s_axi_aclk).'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml: allOf:2:then:properties:clock-names: {'maxItems': 3, 'items': [{'const': 'rx_core_clk'}, {'const': 'dclk'}, {'const': 's_axi_aclk'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260723123838.125145-4-suraj.gupta2@xxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.