Re: [PATCH net-next v5] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

[Andrew Lunn]

> Ans: It is different from the m88e1111 PHY, which may support UTP, fiber, 
>      or combo mode. However, the PHY8824 is only used with UTPs, and 
>      its structure is as follows, which includes UTP0, UTP1,UTP2,UTP3 and USXGMII.
> 
>      RJ45 <----> UTP0 <------>
>      RJ45 <----> UTP1 <------>   USXGMII  <----->  USXGMII(the side of MAC)
>      RJ45 <----> UTP2 <------>
>      RJ45 <----> UTP3 <------>
> 
>      It is similar to phy8821 driver in motorcomm.c, with the difference 
>      being that one has one UTP port and phy8824 has four UTP ports.
>      YT8824_RSSR_FIBER_SPACE is used to access USXGMII reg space, Perhaps it 
>      would be more accurate to call it YT8824_RSSR_USXGMII_SPACE or 
>      YT8824_RSSR_SERDES_SPACE.

O.K, that completely changes my understanding of this device. Yes,
YT8824_RSSR_FIBER_SPACE should change name. And i would include this
diagram in the driver, and indicate how YT8824_RSSR_*_SPACE map to
this.

For the locking, look thought all the code which is touching the
USXGMII side and see if it can be moved into probe().

	Andrew