Re: [PATCH 2/3] gpu: nova-core: Move PFB registers definitions

[Alexandre Courbot]

On Wed Jul 22, 2026 at 12:41 AM JST, Antonin Malzieu Ridolfi via B4 Relay wrote:
> From: Antonin Malzieu Ridolfi <dev@xxxxxxxxxxx>
>

Every patch needs a commit message, even if short.

(also please check whether the issue raised by Sashiko [1] has merit)

[1] https://sashiko.dev/#/patchset/20260721-nova-core-regs-split-v1-0-384fa2a42244@xxxxxxxxxxx?part=2

One more comment inline, but this is pretty much what I had in mind; so
looking pretty good imho!

> Suggested-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> Suggested-by: Danilo Krummrich <dakr@xxxxxxxxxx>
> Signed-off-by: Antonin Malzieu Ridolfi <dev@xxxxxxxxxxx>
> ---
>  drivers/gpu/nova-core/fb.rs           |   4 +-
>  drivers/gpu/nova-core/fb/hal/ga100.rs |   8 ++-
>  drivers/gpu/nova-core/fb/hal/gb100.rs |   6 +-
>  drivers/gpu/nova-core/fb/hal/gb202.rs |   6 +-
>  drivers/gpu/nova-core/fb/hal/gh100.rs |   6 +-
>  drivers/gpu/nova-core/fb/hal/tu102.rs |   8 ++-
>  drivers/gpu/nova-core/fb/regs.rs      | 132 +++++++++++++++++++++++++++++++++-
>  drivers/gpu/nova-core/regs.rs         | 127 --------------------------------
>  8 files changed, 155 insertions(+), 142 deletions(-)
>
> diff --git a/drivers/gpu/nova-core/fb.rs b/drivers/gpu/nova-core/fb.rs
> index 864a34ca20b8..59e715b73479 100644
> --- a/drivers/gpu/nova-core/fb.rs
> +++ b/drivers/gpu/nova-core/fb.rs
> @@ -275,8 +275,8 @@ pub(crate) fn new(chipset: Chipset, bar: Bar0<'_>, gsp_fw: &GspFirmware) -> Resu
>  /// Returns `None` if the WPR2 region is not set.
>  pub(crate) fn wpr2_range(bar: Bar0<'_>) -> Option<Range<u64>> {
>      let (wpr2_lo, wpr2_hi) = (
> -        bar.read(crate::regs::NV_PFB_PRI_MMU_WPR2_ADDR_LO),
> -        bar.read(crate::regs::NV_PFB_PRI_MMU_WPR2_ADDR_HI),
> +        bar.read(regs::NV_PFB_PRI_MMU_WPR2_ADDR_LO),
> +        bar.read(regs::NV_PFB_PRI_MMU_WPR2_ADDR_HI),
>      );
>  
>      if !wpr2_hi.is_wpr2_set() {
> diff --git a/drivers/gpu/nova-core/fb/hal/ga100.rs b/drivers/gpu/nova-core/fb/hal/ga100.rs
> index 3cc1caf361c7..d13c9a826eef 100644
> --- a/drivers/gpu/nova-core/fb/hal/ga100.rs
> +++ b/drivers/gpu/nova-core/fb/hal/ga100.rs
> @@ -9,8 +9,10 @@
>  
>  use crate::{
>      driver::Bar0,
> -    fb::hal::FbHal,
> -    regs, //
> +    fb::{
> +        hal::FbHal,
> +        regs, //
> +    },
>  };
>  
>  use super::tu102::FLUSH_SYSMEM_ADDR_SHIFT;
> @@ -41,7 +43,7 @@ pub(super) fn write_sysmem_flush_page_ga100(bar: Bar0<'_>, addr: u64) {
>  }
>  
>  pub(super) fn display_enabled_ga100(bar: Bar0<'_>) -> bool {
> -    !bar.read(regs::ga100::NV_FUSE_STATUS_OPT_DISPLAY)
> +    !bar.read(crate::regs::ga100::NV_FUSE_STATUS_OPT_DISPLAY)
>          .display_disabled()
>  }
>  
> diff --git a/drivers/gpu/nova-core/fb/hal/gb100.rs b/drivers/gpu/nova-core/fb/hal/gb100.rs
> index 6e0eba101ca1..ec55ec3fc7e1 100644
> --- a/drivers/gpu/nova-core/fb/hal/gb100.rs
> +++ b/drivers/gpu/nova-core/fb/hal/gb100.rs
> @@ -22,9 +22,11 @@
>  
>  use crate::{
>      driver::Bar0,
> -    fb::hal::FbHal,
> +    fb::{
> +        hal::FbHal,
> +        regs, //
> +    },
>      num::usize_into_u32,
> -    regs, //
>  };
>  
>  struct Gb100;
> diff --git a/drivers/gpu/nova-core/fb/hal/gb202.rs b/drivers/gpu/nova-core/fb/hal/gb202.rs
> index b78e0970f66d..69ba35d2ea08 100644
> --- a/drivers/gpu/nova-core/fb/hal/gb202.rs
> +++ b/drivers/gpu/nova-core/fb/hal/gb202.rs
> @@ -12,8 +12,10 @@
>  
>  use crate::{
>      driver::Bar0,
> -    fb::hal::FbHal,
> -    regs, //
> +    fb::{
> +        hal::FbHal,
> +        regs, //
> +    },
>  };
>  
>  struct Gb202;
> diff --git a/drivers/gpu/nova-core/fb/hal/gh100.rs b/drivers/gpu/nova-core/fb/hal/gh100.rs
> index d39fe99537ed..2867ae058d0a 100644
> --- a/drivers/gpu/nova-core/fb/hal/gh100.rs
> +++ b/drivers/gpu/nova-core/fb/hal/gh100.rs
> @@ -10,8 +10,10 @@
>  
>  use crate::{
>      driver::Bar0,
> -    fb::hal::FbHal,
> -    regs, //
> +    fb::{
> +        hal::FbHal,
> +        regs, //
> +    },
>  };
>  
>  struct Gh100;
> diff --git a/drivers/gpu/nova-core/fb/hal/tu102.rs b/drivers/gpu/nova-core/fb/hal/tu102.rs
> index f629e8e9d5d5..2ef04ccb550c 100644
> --- a/drivers/gpu/nova-core/fb/hal/tu102.rs
> +++ b/drivers/gpu/nova-core/fb/hal/tu102.rs
> @@ -9,8 +9,10 @@
>  
>  use crate::{
>      driver::Bar0,
> -    fb::hal::FbHal,
> -    regs, //
> +    fb::{
> +        hal::FbHal, //
> +        regs,

nit: `//` not on last line.