Re: [PATCH 2/3] gpu: nova-core: Move PFB registers definitions
From: Nanonej Dev
Date: Mon Jul 27 2026 - 11:26:09 EST
> Every patch needs a commit message, even if short.
Ok, you mean a body then I guess?
Cause my commit have a message but b4 turned it in the patch subject, so I guess I must also add a body.
> (also please check whether the issue raised by Sashiko [1] has merit)
>
> [1] https://sashiko.dev/#/patchset/20260721-nova-core-regs-split-v1-0-384fa2a42244@xxxxxxxxxxx?part=2
It make sense, but I didn't find how to check the generated doc in docs kernel rust [1].
So for my fix I just reverted to the absolute `crate::fb::SysmemFlush`, but if it is really tied to rustdoc I would be glad to know how to generate it and check it correctly.
[1] https://docs.kernel.org/rust
> One more comment inline, but this is pretty much what I had in mind; so
> looking pretty good imho!
Ok, happy to read that, thanks!
Attachment:
signature.asc
Description: OpenPGP digital signature