RE: [PATCH 13/19] wifi: rtw88: sdio: set up RX aggregation and interrupts for RTL8723BS

[Ping-Ke Shih]

Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
> On July 26, 2026 3:35:02 AM GMT+02:00, Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote:
> >Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote:
> >> On 24/07/2026 21:32, luka.gejak@xxxxxxxxx wrote:
> >> > From: Luka Gejak <luka.gejak@xxxxxxxxx>
> >> >
> >> > Enable the existing RX aggregation setup for this chip and select the
> >> > larger DMA aggregation mode it needs. The RTL8723BS does not raise
> >> > CPWM1, so leave that source out of its interrupt mask, and set the SDIO
> >> > TX control bit the vendor driver uses to have transfers always
> >> > recognised.
> >> >
> >> > Interrupt status is also acknowledged differently: write back only the
> >> > bits that are actually defined, and for this chip only those that are
> >> > unmasked, rather than writing the raw status word back. Writing back
> >> > undefined bits leaves the RTL8723BS raising a persistent interrupt after
> >> > resume. Note that restricting the acknowledgment to defined bits
> >> > applies to the other SDIO parts as well.
> >>
> >> Why does it apply to the others?
> >
> >Luka, could you answer Bitterblue's questions before sending v2?
> >You might write the change in cover letter of v2, but it is very hard
> >for reviewers to know if you did changes based on reviewers' opinions
> >or you have different reasons. More, please give reviewers more time to
> >discuss entirely. I don't know that I should reply your v1 or v2 or RFC?
> >
> >I admit that I have not yet reviewed your patches, but it gets harder
> >to me since there are many versions.
> >
> >Ping-Ke
> >
> 
> Understood, I am sorry about that. I will reply to individual emails
> instead of sending new version from now on. Basically all his comments
> were addressed in v2.

Good to know that. If you could reply that before sending v2, I didn't have
questions about that. 

> Also how long should I wait, because I thought
> it's the best if I send new version which is ~500 lines shorter so
> there is less to review, but I will wait if you want, just tell me how
> much? 

If reviewers comment your patches and you fully agree them, you
can reply comments and send new patches in one or two days.

If some comments are uncertain, please discuss and convince reviewers
why/how it should be, and then send new version.

If you want to update a version and no one is commenting your patches yet,
reply the patch yourself to tell reviewers to ignore your patches, and
then send new version. 

> Right now latest version is v2. Do you want me to respond to
> Bitterbind's individual emails now

I suggest you can do that. I also want to know how/what you will handle
the things Bitterblue commented. Checking your reply will be simpler 
than comparing v1 and v2 or checking v2 commit messages.

More, we don't know if we want to go back to see how we do the changes
in the future. These will be good records. 

> or do that for any new comments in v2?

For me, I will review v2. Please leave your reply there if people have comments. 

Ping-Ke