Re: [PATCH] drivers: staging: octeon: ethernet: removed unneeded parentheses
From: Greg Kroah-Hartman
Date: Tue Jul 28 2026 - 03:37:34 EST
On Tue, Jul 21, 2026 at 09:04:17PM +0500, Faisal Mukhtar wrote:
> removed redundant inner parentheses around "interface < 2"
> in 3 if statement instances within the file ethernet.c,
> got the warning by running checkpatch.pl script on the file.
>
> Signed-off-by: Faisal Mukhtar <mukhtarfaisal03@xxxxxxxxx>
> ---
> drivers/staging/octeon/ethernet.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index f3fa221f452e..5083d9596972 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -247,7 +247,7 @@ static int cvm_oct_common_change_mtu(struct net_device *dev, int new_mtu)
>
> dev->mtu = new_mtu;
>
> - if ((interface < 2) &&
> + if (interface < 2 &&
checkpatch should not have warned you about this, as it is correct. Be
sure to use the latest version.
thanks,
greg k-h