Re: [PATCH net-next v2] net: phylink: add phylink_pcs_loopback() method for PCS loopback support
From: Zxyan Zhu
Date: Tue Jul 28 2026 - 09:30:01 EST
On Tue, Jul 28, 2026 at 10:41:12AM +0200, Maxime Chevallier wrote:
> I'm actually seriously wondering if we shouldn't just stick to MAC
> loopback only for stmmac selftests. [...]
> Using an external loopback (in PCS, in PHY, somewhere else...) doesn't
> bring anything to the table given what we are testing today, which is
> internal stmmac behaviour. The MAC loopback happens at the GMII level,
> so everything we are currently testing happens before that.
You're right. MAC loopback at the GMII level already covers everything
stmmac selftests actually test (DMA, filtering, VLAN, checksum offload,
etc.). PCS acts only as external transceivers beyond the MAC boundary
and do not bring additional test coverage.
Given that, I will drop this PCS loopback patch series.
Thanks for the explanation!
Zxyan