Re: [PATCH 1/2] audit: drop BUG_ON() from audit_add_to_parent()

From: Ricardo Robaina

Date: Tue Jul 28 2026 - 18:50:05 EST


On Tue, Jul 28, 2026 at 3:53 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
>
> On Jul 28, 2026 Ricardo Robaina <rrobaina@xxxxxxxxxx> wrote:
> >
> > The BUG_ON(!mutex_is_locked(&audit_filter_mutex)) check in
> > audit_add_to_parent() will panic the kernel if the mutex is not held,
> > which is too severe for this situation.
> >
> > Replace it with lockdep_assert_held(), instead.
> >
> > Signed-off-by: Ricardo Robaina <rrobaina@xxxxxxxxxx>
> > ---
> > kernel/audit_watch.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Merged into audit/dev, thanks.
>
> --
> paul-moore.com
>

Thanks, Paul!