Re: [PATCH v5 2/4] arm64: dts: qcom: Enable USB controllers on Shikra CQS platform

[Krishna Kurapati]

On 7/27/2026 8:09 PM, Konrad Dybcio wrote:
> On 7/23/26 12:33 PM, Krishna Kurapati wrote:
> > On Shikra CQS platform, usb-role-switch is handled by PM4125 on primary
> > Type-C port and Cypress PD controller CYPD6129 on second Type-C port.
> >
> > Since those changes are not yet present, enabling both USB controllers
> > in device mode.
> >
> > Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 35 +++++++++++++++++++++++++++++
> >   1 file changed, 35 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> > index b3f19a64d7ae..006e24a62f5c 100644
> > --- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> > @@ -38,3 +38,38 @@ &sdhc_1 {
> >   
> >   	status = "okay";
> >   };
> > +
> > +&usb_1 {
> > +	dr_mode = "peripheral";
> > +
> > +	status = "okay";
> > +};
>
> $ rg shikra-evk.dtsi arch
> arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
> 9:#include "shikra-evk.dtsi"
>
> arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> 9:#include "shikra-evk.dtsi"
>
> arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> 9:#include "shikra-evk.dtsi"
>
> I think I asked either in private or in public, don't remember at this
> point, just enable these controller once. They are all the same board
> with the chip and PMICs swapped. Override just the supplies in the final
> DTS files.
Hi Konrad,

Shall I enable all platforms in one patch or in separate patches.

Reason why I am asking is if I enable controller and phys on cqs 
platform in patch -2, then cqm and iqs will have controller enabled, but 
not phys causing inconsistency in those platforms if only the patch-2 
would be applied.

Regards,
Krishna,