Re: [PATCH v5 2/4] arm64: dts: qcom: Enable USB controllers on Shikra CQS platform

[Konrad Dybcio]

On 7/29/26 7:13 AM, Krishna Kurapati wrote:
> 
> 
> On 7/27/2026 8:09 PM, Konrad Dybcio wrote:
>> On 7/23/26 12:33 PM, Krishna Kurapati wrote:
>>> On Shikra CQS platform, usb-role-switch is handled by PM4125 on primary
>>> Type-C port and Cypress PD controller CYPD6129 on second Type-C port.
>>>
>>> Since those changes are not yet present, enabling both USB controllers
>>> in device mode.
>>>
>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
>>> ---

[...]

>>> +&usb_1 {
>>> +    dr_mode = "peripheral";
>>> +
>>> +    status = "okay";
>>> +};
>>
>> $ rg shikra-evk.dtsi arch
>> arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
>> 9:#include "shikra-evk.dtsi"
>>
>> arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
>> 9:#include "shikra-evk.dtsi"
>>
>> arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
>> 9:#include "shikra-evk.dtsi"
>>
>> I think I asked either in private or in public, don't remember at this
>> point, just enable these controller once. They are all the same board
>> with the chip and PMICs swapped. Override just the supplies in the final
>> DTS files.
>>
> Hi Konrad,
> 
> Shall I enable all platforms in one patch or in separate patches.
> 
> Reason why I am asking is if I enable controller and phys on cqs platform in patch -2, then cqm and iqs will have controller enabled, but not phys causing inconsistency in those platforms if only the patch-2 would be applied.

One is okay because of the reasons you mentioned. We normally prefer
one per, but this is a bit of a special case, since these boards
co-depend on the same include file

Konrad