Re: [PATCH v4 2/3] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file

[Konrad Dybcio]

On 7/24/26 11:54 AM, Varadarajan Narayanan wrote:
> RDP504 has USB, PCIe and SPI NAND devices populated. EMMC and NAND
> share the GPIOs. The board has to be reworked to change from EMMC
> to NAND variant. Rename ipq5210-rdp504.dts as ipq5210-rdp504-common.dtsi
> and include it in variant specific DTS file.
> 
> Describe the fixed USB regulators, PCIe reset GPIOs, QPIC SPI NAND flash
> and required pinctrl states. Enable QPIC BAM, USB and PCIe for the board.
> 
> Remove ipq5210-rdp504.dtb from Makefile to avoid build break.

You're essentially removing support for the board for this commit
Instead, this commit could be:

create .dtsi (90% of the current .dts)
add #include .dtsi to .dts

and patch 3 could be:

create another dts

preferably then, all new additions would be done in patch 4 altering
just the dtsi

Konrad