Re: [PATCH v2 04/11] wifi: rtw88: fw: fix the reserved page upload on RTL8723BS

[luka . gejak]

From: Luka Gejak <luka.gejak@xxxxxxxxx>

On 27/07/2026 07:37, Ping-Ke Shih wrote:
>> +/* REG_DWBCN1_CTRL bit 20 (SW_BCN_SEL for port 0), relative to byte +2 */
>> +#define BIT_OFFSET_DWBCN1_SW_BCN_SEL_PORT0     (20 - 16)
> 
> define along its register REG_DWBCN1_CTRL

Done. reg.h now has

  #define REG_DWBCN1_CTRL		0x0228
  #define BIT_DWBCN1_SW_BCN_SEL_PORT0	BIT(20)

and the write is

  val &= ~(BIT_DWBCN1_SW_BCN_SEL_PORT0 >> 16);

as you suggested.

> Currently, not use networking specific comment style anymore
> 
>    /*
>     * first line
>     * second
>     */

Right, I had missed 82b8000c28b5 ("net: drop special comment style").
Converted every block comment the series adds, in all patches.

Best regards,
Luka Gejak