Re: [PATCH 4/6] mm/page_io: rename bio_associate_blkg_from_page()
From: Matthew Wilcox
Date: Tue Aug 11 2026 - 16:31:27 EST
On Fri, Aug 07, 2026 at 10:30:22PM +0300, Tal Zussman wrote:
> On 8/7/26 2:56 PM, Matthew Wilcox wrote:
> > It's s shame this isn't const-qualified (after all, we don't modify the folio).
> > That needs folio_memcg_charged() to take a const folio pointer, which it
> > could. And folio_memcg_blkg_css() and folio_memcg(). That's a followup
> > patch though.
> >
>
> I had the same thought when looking at this and went all the way down the
> callchain to dump_page(). I didn't want to flood the list with patches, but
> happy to send a couple follow-up patches once this is in mm-new.
As the person who did the dump_page() const-qualification ... you're
welcome ;-) (preliminary work in 2021 with 5f7dadf3958f and some
preceding patches, then the actual constification in 2024 with
29cfe7556bfd and some precedig patches)