Re: [PATCH v2 0/3] Add driver for Invensense ICM42370P accelerometer

[Andy Shevchenko]

On Thu, Aug 13, 2026 at 02:26:09PM +0200, Kanak Shilledar wrote:
> Invensense ICM42370P is a high performance MEMS MotionTracking 3-axis
> accelerometer. It supports I2C, I3C and SPI protocols. It has a 2.25kB
> FIFO and two programmable interrupts with support for ultra-low-power
> wake-on-motion support. It has a built-in temperature sensor. This
> patch series adds basic support for the sensor with functionality of
> performing raw reads and writes along with buffered reads via the I2C
> interface.
> 
> This device contains 4 register banks for configuring the device called
> MREG0, MREG1, MREG2 and MREG3. Unlike other devices from the same
> vendor, this contains a very different way of accessing the register
> banks apart from the default user bank 0 (MREG0). The register bank access
> procedure is mentioned in the datasheet [1] Section 13. Due to this
> specific reason and that it doesn't have a gyro sensor, it is implemented
> as a standalone driver.
> 
> This device has 3 formats for the FIFO structure (datasheet [1] Section
> 6), currently only FIFO packet format 1 is supported, others
> formats can be added as part of future work.
> 
> The device supports EDGE and LEVEL triggered interrupts, refer the dt-binding
> for example of how the devicetree should be setup.
> 
> The driver is inspired from iio/imu/inv_icm42600.
> 
> Thanks to the reviewers for all the time you spent going through the
> code and the comments. The changes for v2 are quite a lot and I hope
> that every important change is documented in the changelog. After
> implementing the suggested changes, the driver is in a far better state
> than v1.

> [1] https://uat.invensense.com/en-us/products/3-axis/icm-42370-p

Can be added as a Datasheet tag here (and be spread by `b4` to all patches in
the series, which I think is fine).

Can you split the first patch to be based on the features implemented?
Something like

- patch 0: DT binding
- patch 1: very basic (but working) driver
- patch 2...n: Features 1...(n-1)

-- 
With Best Regards,
Andy Shevchenko