Re: [PATCH v2 0/3] Add driver for Invensense ICM42370P accelerometer

[Kanak Shilledar]

Hi Andy,
Thanks for the comments.

On Mon, 2026-08-17 at 10:19 +0300, Andy Shevchenko wrote:
> [Some people who received this message don't often get email from
> andriy.shevchenko@xxxxxxxxx. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ;]
> 
> On Thu, Aug 13, 2026 at 02:26:09PM +0200, Kanak Shilledar wrote:
> > Invensense ICM42370P is a high performance MEMS MotionTracking 3-
> > axis
> > accelerometer. It supports I2C, I3C and SPI protocols. It has a
> > 2.25kB
> > 
> > The driver is inspired from iio/imu/inv_icm42600.
> > 
> > Thanks to the reviewers for all the time you spent going through
> > the
> > code and the comments. The changes for v2 are quite a lot and I
> > hope
> > that every important change is documented in the changelog. After
> > implementing the suggested changes, the driver is in a far better
> > state
> > than v1.
> 
> > [1] https://uat.invensense.com/en-us/products/3-axis/icm-42370-p
> 
> Can be added as a Datasheet tag here (and be spread by `b4` to all
> patches in
> the series, which I think is fine).

Thanks, for pointing that out. We will use "Datasheet:" in our next
version.
> 
> Can you split the first patch to be based on the features
> implemented?
> Something like
> 
> - patch 0: DT binding
> - patch 1: very basic (but working) driver
> - patch 2...n: Features 1...(n-1)

As @jonathan said to squash the two files (buffer.c and core.c into
just core.c), I split out the implementation in various commits. Here
is what I plan to split them into, let me know if you think anything
else should be split into multiple commits.

* patch 0: DT binding
* patch 1: basic working driver
* patch 2: implementing temperature sensor
* patch 3: implementation of accelerometer configuration and power
management
* patch 4: implementing user bank switching (mreg_read/write)
* patch 5: implemtation of timestamp related things
* patch 6: implementing advanced accelerometer parts
* patch 7: parsing of mount-matrix
* patch 8: add basic irq handler and parse devicetree interrupts
* patch 9: adding buffer support

The buffer functionality has a lot of dependent changes and thus
splitting them may cause "unused-functions/symbols" warnings. So, it is
better to have them in a single commit.

> --
> With Best Regards,
> Andy Shevchenko

Thanks and Regards,
Kanak Shilledar

Attachment: signature.asc
Description: This is a digitally signed message part