Re: [PATCH v5 3/6] iio: dac: ad5504: separate ACPI and DT paths

[Joshua Crofts]

On Fri, 21 Aug 2026 06:24:45 -0400
Taha Ed-Dafili <0rayn.dev@xxxxxxxxx> wrote:
> @@ -285,16 +292,20 @@ static int ad5504_probe(struct spi_device *spi)
>  
>  	st = iio_priv(indio_dev);
>  
> -	ret = devm_regulator_get_enable_read_voltage(dev, "vcc");
> -	if (ret < 0 && ret != -ENODEV)
> -		return ret;
> -	if (ret == -ENODEV) {
> -		if (pdata->vref_mv)
> -			st->vref_mv = pdata->vref_mv;
> -		else
> -			dev_warn(dev, "reference voltage unspecified\n");
> +	if (is_acpi_device_node(dev_fwnode(dev))) {
> +		st->vref_mv = AD5504_VREF_ACPI_DEFAULT_mV;
>  	} else {
> -		st->vref_mv = ret / 1000;
> +		ret = devm_regulator_get_enable_read_voltage(dev, "vcc");
> +		if (ret < 0 && ret != -ENODEV)
> +			return ret;
> +		if (ret == -ENODEV) {
> +			if (pdata->vref_mv)
> +				st->vref_mv = pdata->vref_mv;
> +			else
> +				dev_warn(dev, "reference voltage unspecified\n");
> +		} else {
> +			st->vref_mv = ret / 1000;

ret / (MICRO / MILLI)

-- 
Kind regards,
Joshua Crofts