Re: [PATCH v3 2/2] x86/amd_node: Remove smn_exclusive

From: Borislav Petkov

Date: Sun Aug 30 2026 - 22:31:42 EST


On Tue, Aug 25, 2026 at 05:48:03PM -0400, Jason Andryuk wrote:
> - root = amd_roots[node];
> - if (!root)
> + /*
> + * non-NULL amd_roots indicates pci_request_config_region_exclusive()
> + * succeeded and userspace cannot access the registers.
> + */
> + if (!amd_roots)

So then this should be

if (amd_roots)
return err;

?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette