Re: [PATCH] clk: mediatek: Add missing depend for COMMON_CLK_MT8173

[Ricardo Ribalda]

Hi Chen-Yu

On Mon, 31 Aug 2026 at 11:03, Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote:
>
> On Mon, Aug 31, 2026 at 4:50 PM Ricardo Ribalda <ribalda@xxxxxxxxxxxx> wrote:
> >
> > PM_GENERIC_DOMAINS_OF depends on OF, by adding a select to it without
> > adding a depend on OF, the following warning is triggered:
> >
> > WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF
> >   Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n]
> >   Selected by [y]:
> >   - COMMON_CLK_MT8173_MFGTOP [=y] && COMMON_CLK [=y] && (ARCH_MEDIATEK || COMPILE_TEST [=y]) && COMMON_CLK_MT8173 [=y] && PM [=y]
>
> I guess this happens on COMPILE_TEST=y with !OF architectures.

It was triggered by media-ci.
https://gitlab.freedesktop.org/linux-media/users/hverkuil/-/pipelines/1736835/test_report?job_name=configs

A way to repro is:
make allyesconfig
scripts/config -d OF
make olddefconfig

>
> > This patch explicitly adds a dependency on OF to solve this issue.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: ebd0b73d2137 ("clk: mediatek: Add mt8173-mfgtop driver")
> > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
>
> Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
>
> Thanks!



-- 
Ricardo Ribalda