Re: [PATCH v3 1/9] ASoC: dt-bindings: qcom,qaif-cpu: Add binding

[Harendra Gautam]

> >> The DT binding filename and compatible string do not match (qcom,qaif-cpu.yaml vs qcom,shikra-qaif-cpu).
> >> Usually DT binding filenames are aligned with the compatible string for clarity.
> >> Is there a reason for the naming mismatch?
> > The filename reflects the controller; the compatible is
> > variant-specific. This follows the same convention as
> > qcom,lpass-cpu.yaml.
> >>
>
> There is no compatible for controller and the only top-level compatible
> listed there is "qcom,shikra-qaif-cpu", so that is your filename.
>
> And I already asked about this in v1. Why does this have to be repeated
> at v3?
The QAIF hardware IP is the same across platforms, only the board
integration details differ. The binding is meant to describe the IP
generically, with board-specific compatibles like qcom,shikra-qaif-cpu
used to distinguish variants. I had qcom,qaif-cpu as the generic
compatible in v2 but removed it in v3 as I was not clear about the
guideline. Could you please suggest the right approach for the
compatible and filename in this case?
>
> What about other comments from v1? Where they implemented?
v3 carries major changes in binding and code, which addresses all the
previous comments from all patches of v1 & v2. Requesting you to
please review v3.
-Harendra
>
> Best regards,
> Krzysztof