Re: [PATCH v3 1/9] ASoC: dt-bindings: qcom,qaif-cpu: Add binding

[Harendra Gautam]

On Tue, Sep 1, 2026 at 8:26 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxxxxxxxx> wrote:
>
> On 01/09/2026 16:46, Harendra Gautam wrote:
> >>>> The DT binding filename and compatible string do not match (qcom,qaif-cpu.yaml vs qcom,shikra-qaif-cpu).
> >>>> Usually DT binding filenames are aligned with the compatible string for clarity.
> >>>> Is there a reason for the naming mismatch?
> >>> The filename reflects the controller; the compatible is
> >>> variant-specific. This follows the same convention as
> >>> qcom,lpass-cpu.yaml.
> >>>>
> >>
> >> There is no compatible for controller and the only top-level compatible
> >> listed there is "qcom,shikra-qaif-cpu", so that is your filename.
> >>
> >> And I already asked about this in v1. Why does this have to be repeated
> >> at v3?
> > The QAIF hardware IP is the same across platforms, only the board
> > integration details differ. The binding is meant to describe the IP
> > generically, with board-specific compatibles like qcom,shikra-qaif-cpu
>
> The binding does not describe the IP generically, because bindings are
> not generic.
>
> > used to distinguish variants. I had qcom,qaif-cpu as the generic
> > compatible in v2 but removed it in v3 as I was not clear about the
> > guideline. Could you please suggest the right approach for the
> > compatible and filename in this case?
>
> Same comment, literally as v1.
>
> Filename should match compatible, as in this case since it is single
> compatible, filename should be equal to the compatible. So first you
> determine what is your compatible and then you copy paste that string
> into the filename and $id path.
Understood. Thanks for feedback, The filename should be
qcom,shikra-qaif-cpu.yaml and the $id path should be updated to match.
I will fix this in the next version.
-Harendra
>
> Best regards,
> Krzysztof