Re: [PATCH v2] platform/x86: asus-wmi: fix FA401 series keyboard sleep strobe

[ido]

Hi Denis,

Thanks for the feedback!

That's a very fair point regarding userspace and kernel policy. I'll try to
find a more proper workaround.

Regards,
Ido


On Wed, Sep 2, 2026 at 6:54 PM Denis Benato <denis.benato@xxxxxxxxx> wrote:
> Hi Idotoho!
>
> I tried to change the ASUS TUF interface for leds moving it to asus-armoury once,
> I dropped it in the end, but I got these defines and bitfields right: you can reuse
> my code code if you want, just leave the interface in asus-wmi.
>
> Also about this restore the backlight setting before entering sleep: do we really
> want the kernel to decide to override a userspace decision to shine some leds
> in s2idle? My understanding is that if this is a userspace "missing feature"
> (the ability to configure what happens to LEDs upon entering s2idle) it is the
> userspace that has to be improved, not for the kernel to force a decision.
>
> Best regards,
> Denis
> >> +                                      0, NULL);
> >> +    }
> >> +
> >>      return 0;
> >>  }
> >>
> >> diff --git a/drivers/platform/x86/asus-wmi.h b/drivers/platform/x86/asus-wmi.h
> >> index 5cd4392b9..69d224774 100644
> >> --- a/drivers/platform/x86/asus-wmi.h
> >> +++ b/drivers/platform/x86/asus-wmi.h
> >> @@ -52,6 +52,7 @@ struct quirk_entry {
> >>       */
> >>      int no_display_toggle;
> >>      u32 xusb2pr;
> >> +    bool kbd_rgb_state_quirk;
> >>  };
> >>
> >>  struct asus_wmi_driver {
> >>