Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers
From: Krishna Kurapati
Date: Wed Sep 02 2026 - 13:37:30 EST
On 9/2/2026 7:40 PM, Konrad Dybcio wrote:
On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote:Yes, I wanted to add the missing hs_phy_irq. I didn't want to bundle in the DT along with the usb binding changes. DT change was posted separately:
On 31/08/2026 11:03, Krishna Kurapati wrote:
On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
Currently for Glymur non-multiport USB controllers, number of interrupts
are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
present.
[...]
As per the harware specification, the controllers do have both- qcom,eliza-dwc3
+ - qcom,glymur-dwc3
- qcom,ipq4019-dwc3
- qcom,ipq8064-dwc3
- qcom,kaanapali-dwc3
This changes the ABI without an explanation.
hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that
info. Will update the commit message accordingly.
So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was
incomplete? Lack of context here is not helping.
If they have these IRQs but it does not matter, then it is not a good
reason to change ABI and you should just add the clock as optional to
the end. Was this binding already released? I think yes.
IIUC the intent of the patch is to allow specifying the currently
missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]).
Bundling the DT change would have made that easier.
https://lore.kernel.org/all/20260803-glymur-dt-usb-fixes-v1-1-0f5f52853102@xxxxxxxxxxxxxxxx/
Regards,
Krishna,