Re: [PATCH net] nexthop: initialize extack in nh_res_bucket_migrate()
From: Ido Schimmel
Date: Thu Sep 03 2026 - 03:45:21 EST
On Tue, Sep 01, 2026 at 03:18:27PM +0530, Kalpan Jani wrote:
> On Tue, Jul 14, 2026 at 01:44:28PM +0300, Ido Schimmel wrote:
> > remove_nh_grp_entry() also doesn't initialize extack, but
> > call_nexthop_notifiers() is using NL_SET_ERR_MSG(). Still, the same
> > problem can happen if a listener is returning an error without setting
> > extack. Please send a separate patch (targeted at net-next, no Fixes
> > tag) to make remove_nh_grp_entry() consistent with
> > nh_res_bucket_migrate().
>
> Hi Ido,
>
> Noticed this hasn't been picked up yet - happy to send that patch if
> nobody else is already on it. Will target net-next, no Fixes tag, and
> keep it consistent with your fix above.
I checked and this does need a Fixes tag. I will send a patch later
today.
Thanks