Re: [PATCH 6/6] arm64: dts: qcom: Add initial support for Nord Ride Embedded board

[Shawn Guo]

On Wed, Sep 02, 2026 at 04:00:52PM +0200, Konrad Dybcio wrote:
> On 8/31/26 5:21 AM, Shawn Guo wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> > 
> > Add the initial device tree for the Nord Ride Embedded board, the
> > non-SCMI variant of the SA8797P automotive Ride board.
> 
> [...]
> 
> > +		vreg_l7a_1p2: ldo7 {
> > +			regulator-name = "vreg_l7a_1p2";
> > +			regulator-min-microvolt = <1200000>;
> > +			regulator-max-microvolt = <1200000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> > +			regulator-always-on;
> > +			regulator-boot-on;
> 
> You mark _a lot_ of regulators as always- and boot-on - is that
> necessary for all of them?

Ah, sorry! You already had the comment on nord-rrd.dts. I forgot to apply
it on nord-ride-embedded.dts. Will fix.

> 
> [...]
> 
> > +	/* PMIC H - "UPMH" satellite (CD90-73961-1) - SID 0x7, Bus E0 */
> 
> leftover?

Since we agreed that a bit comment is useful [1], I guess you are saying
the "satellite (CD90-73961-1)" part shouldn't be there. I will get the
comment aligned with nord-rrd.dts.

> 
> [...]
> 
> > +	/* PMIC I - "UPMI" satellite (CD90-73961-1) - SID 0x8, Bus E0 */
> 
> likewise, a couple times
> 
> [...]
> 
> > +		vreg_s2i_gfx0: smps2 {
> > +			regulator-name = "vreg_s2i_gfx0";
> > +			regulator-min-microvolt = <300000>;
> > +			regulator-max-microvolt = <1200000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> > +			regulator-allow-set-load;
> > +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> > +						   RPMH_REGULATOR_MODE_HPM>;
> > +		};
> > +
> > +		vreg_s7i_mm: smps7 {
> > +			regulator-name = "vreg_s7i_mm";
> > +			regulator-min-microvolt = <300000>;
> > +			regulator-max-microvolt = <1200000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> > +			regulator-allow-set-load;
> > +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> > +						   RPMH_REGULATOR_MODE_HPM>;
> 
> Are these actually exposed as regulators and not RPMHPDs?

Great catch, Konrad! These are rpmhpd-managed resources and shouldn't be
here. I will drop them.

Shawn

[1] https://lore.kernel.org/all/b522c9b4-4944-4fb2-94f9-bd2553690901@xxxxxxxxxxxxxxxx/